great rework #54
great rework #54
Conversation
this:
- drops support for legacy windows systems
- removes functionality targeting those legacy systems
- simplifies module structure accordingly
- corrects datatypes and values to match up-to-date systems
- reworks tests adequately
- drops dependency to liamjbennett/puppet-win_facts as it's not needed
anymore
- updates dependencies/requirements
voxpupuli CI pipeline treats trailing whitespaces in a markdown file as errors, which makes it impossible to have explicit linebreaks without starting a new paragraph; so we add a bunch of paragraphs instead.
Lightning-
force-pushed
the
great_rework
branch
3 times, most recently
from
0c80681 to
b26f196
Compare
Lightning-
added
enhancement
|
note: development branch has been in our production with dozens of hosts for months now and proved to be working and safe |
|
@Lightning- Looks good and obviously a lot of work put into an otherwise unmaintained module. (Really not trying to put you off, but in future, please make sure to get a review before merging). Thanks for the work. If you want to create a release PR, you might find it useful to first create a release summary issue with content that will be included in the changelog. These work great for major releases with notable breaking changes. From memory, you have to create a milestone for the release. Then create an issue where the first comment will be the summary, assign it to the milestone, apply the release-summary label and close the issue before running the changelog task. |
This is a complete module rewrite/modernization (almost from scratch, but being inspired by what has been there before).
Beyond the Puppet language modernization (and corresponding module redesign) we can summarize the relevant (and breaking) changes as follows:
power_schemesandpower_devicesand structure the module around them